[5.0.3] Add column name null checks in default FK and PK name calculation #23697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23672
Description
GetColumnNames(StoreObjectIdentifier)returnsnullfor properties that are not mapped to the specifier store object. HoweverGetDefaultName()didn't account for this.Customer Impact
User models that use table splitting and have FKs to other table will result in an unhelpful
ArgumentNullException. A workaround would be to specify the key and index store names explicitly, but this would be unfeasible for large models as the exception doesn't provide information on which are the offending ones.How found
Customer reported on 5.0.1.
Test coverage
We have added more test coverage in this PR.
Regression?
Yes
Risk
Low. This just adds two
nullchecks.