Throw a better exception for relationships to keyless entity types #26143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
|
@Pilchie For approval |
|
Approved for EF Core 6.0 |
ajcvickers
approved these changes
Sep 23, 2021
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24373
Description
Using a keyless entity type as the principal is invalid, however we didn't have an explicit check for this.
Customer impact
Without this an NRE is thrown when a keyless entity type is used as the principal.
How found
Customer
Regression
No.
Testing
Test for this scenario added in the PR.
Risk
Low, just a better exception message.