[6.0] Respect AsNoTrackingWithIdentityResolution in AsTracking method #26233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #26227. This fixes a 🤦 bug where calling `AsTracking` with `NoTrackingWithIdentityResolution` was not being respecting and the query would be executed with `NoTracking` instead.
|
@Pilchie for 6.0. |
TAGC
reviewed
Oct 1, 2021
AndriySvyryd
approved these changes
Oct 2, 2021
|
Approved for EF Core 6.0 GA. |
|
@ajcvickers do we want to backport this? |
|
@roji We decided not in triage. The workaround is really easy. And it could break existing apps by silently changing behavior, even though the behavior is technically wrong. |
|
Right, sorry - forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26227.
This fixes a 🤦 bug where calling
AsTrackingwithNoTrackingWithIdentityResolutionwas not being respecting and the query would be executed withNoTrackinginstead.