Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool to roll forward to latest major version of runtime installed. #27671

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

AraHaan
Copy link
Member

@AraHaan AraHaan commented Mar 20, 2022

This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes.

Fixes: #27660.
Discovered at: #27660 (comment)

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features) N/A
  • Code follows the same patterns and style as existing code in this repo (tool projects TFM change)

@AraHaan AraHaan changed the title Update tool to require .NET 6 at minimum. Update tool to require .NET 6 / .NET Framework 4.6.1 at minimum. Mar 20, 2022
@AraHaan AraHaan force-pushed the patch-2 branch 2 times, most recently from ec7fe33 to c876901 Compare March 20, 2022 09:35
@AraHaan
Copy link
Member Author

AraHaan commented Mar 20, 2022

Welp just tested these changes and it looks like there is 1 more place where it expects ef.dll in .nuget\packages\dotnet-ef\7.0.0-dev\tools\net6.0\any\tools\netcoreapp2.0\any\ 😔

Edit: found it just now.

@AraHaan
Copy link
Member Author

AraHaan commented Mar 20, 2022

cc: @roji, @ajcvickers does this look good to you on the fix for my issue?

@AraHaan AraHaan mentioned this pull request Mar 20, 2022
3 tasks
@AraHaan AraHaan marked this pull request as ready for review March 20, 2022 13:12
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes seem unnecessary and won't actually address the issue you're seeing.

src/ef/ef.csproj Show resolved Hide resolved
src/dotnet-ef/dotnet-ef.csproj Outdated Show resolved Hide resolved
…led.

This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes.

Fixes: dotnet#27660.

Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan AraHaan changed the title Update tool to require .NET 6 / .NET Framework 4.6.1 at minimum. Update tool to roll forward to latest major version of runtime installed. Mar 22, 2022
@AraHaan
Copy link
Member Author

AraHaan commented Mar 22, 2022

The change works.

@AraHaan AraHaan requested a review from bricelam March 22, 2022 21:43
@AraHaan
Copy link
Member Author

AraHaan commented Mar 23, 2022

@bricelam I have completed the requested changes and verified that they work still on fixing the issue.

@AraHaan
Copy link
Member Author

AraHaan commented Mar 25, 2022

Now the github actions check should be rerun and it should pass.

@ajcvickers ajcvickers merged commit 06b2b1f into dotnet:main Mar 28, 2022
@ajcvickers
Copy link
Member

Merged following team review. Cosmos failure was a known issue.

Thanks @AraHaan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileLoadException: System.Runtime v6.0.0 when using scaffolder with latest dotnet-7 feed dotnet-ef tool.
3 participants