-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tool to roll forward to latest major version of runtime installed. #27671
Conversation
ec7fe33
to
c876901
Compare
Welp just tested these changes and it looks like there is 1 more place where it expects ef.dll in Edit: found it just now. |
137eda5
to
7aeb4a7
Compare
cc: @roji, @ajcvickers does this look good to you on the fix for my issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes seem unnecessary and won't actually address the issue you're seeing.
…led. This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes. Fixes: dotnet#27660. Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
The change works. |
@bricelam I have completed the requested changes and verified that they work still on fixing the issue. |
Now the github actions check should be rerun and it should pass. |
Merged following team review. Cosmos failure was a known issue. Thanks @AraHaan. |
This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes.
Fixes: #27660.
Discovered at: #27660 (comment)