Reimplement MaxBatchSize as a pre-check #27696
Conversation
|
|
||
| _maxBatchSize = Math.Min( | ||
| options.Extensions.OfType<SqlServerOptionsExtension>().FirstOrDefault()?.MaxBatchSize ?? DefaultMaxBatchSize, | ||
| MaxMaxBatchSize); |
There was a problem hiding this comment.
@AndriySvyryd we may want to start throwing if the MaxMaxBatchSize is exceeded, rather than silently reducing it (after all the user explicitly wants something else). Would be a pretty minor breaking change.
There was a problem hiding this comment.
I wouldn't worry about that. With the current way if MaxMaxBatchSize changes that user just needs to upgrade
There was a problem hiding this comment.
My thought was to either allow users to explicitl go beyond the 1000 MaxMaxBatchSize (it's their responsibility...), or to throw if they try to do so, rather than silently reduce to 1000.. But not very important.
For better perf on SQLite (dotnet#27681) Also moves the handling of MaxBatchSize to ReaderModificationCommandBatch and does some cleanup.
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
For better perf on SQLite (#27681)
Also moves the handling of MaxBatchSize to ReaderModificationCommandBatch and does some cleanup.