Query: Allow final GroupBy navigation #29205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Sep 26, 2022
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
ajcvickers
changed the title
smitpatel
force-pushed
the
smit/issue29199
branch
from
4877ab1
to
eb14d2f
Compare
maumar
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29199
Description
EF7 added support for
GroupByentity type. This is not working when that entity type is defined by a navigation property. For example:Customer impact
This was one of the customer-requested scenarios that the EF7 feature as intended to enable.
How found
Testing customer-reported issues against EF7.
Regression
No; new feature in EF7.
Testing
New testing added.
Risk
Low, small fix to new feature.