Most of explicit and lazy loading for no-tracking queries #29865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #10042 Current limitations are: - The lazy-loading delegate injection doesn't support tracking of when an navigation is loaded or not; I have an idea for this - There is no identity resolution when the entities are not tracked, even if the query behavior is NoTrackingWithIdentityResolution - The model should validated for only a single service property for a given type I will submit PRs and/or file issues for these things.
ajcvickers
force-pushed
the
LoadedByProxy1209
branch
from
0791ae6
to
3c1fdd7
Compare
| var memberType = memberInfo.GetMemberType(); | ||
| if (entityType.GetServiceProperties().Any(p => p.ClrType == memberType)) | ||
| { | ||
| continue; |
There was a problem hiding this comment.
Might be worth logging a message
There was a problem hiding this comment.
Filed #29881 for this. Rather than warning here, it might be better to let them accumulate and then fail in model validation.
AndriySvyryd
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10042
Current limitations are:
I will submit PRs and/or file issues for these things.