Json reader sandbox rebase #31076
Json reader sandbox rebase #31076
Conversation
|
@ajcvickers fyi |
maumar
force-pushed
the
json_reader_sandbox_rebase
branch
from
edc51f8
to
e0b0e8c
Compare
|
@ajcvickers pushed new version, updated to use your new json type mapping infra and did some clean up |
| @@ -318,6 +318,8 @@ protected override Expression VisitShapedQuery(ShapedQueryExpression shapedQuery | |||
| shapedQueryExpression.ShaperExpression, | |||
| out var relationalCommandCache, out var readerColumns, out var relatedDataLoaders, ref collectionCount); | |||
|
|
|||
| var foo = ExpressionPrinter.Print(shaper); | |||
There was a problem hiding this comment.
breakpoint here to see the see the final expression for debugging
| } | ||
|
|
||
| shaperBlockExpressions.Add(entityShaperMaterializerVariable); | ||
| var rewrittenEntityShaperMaterializer = new JsonEntityMaterializerRewriter2( |
There was a problem hiding this comment.
breakpoint here to see the shaper before (i.e. regular entity materializer with random access to the properties in the reader/JSON DOM) and after (basic streaming structure, but without JSON property reads yet - still all in terms of ValueBuffers). Still doesn't handle the tracking scenario (where we already have entity in state manager but need to read/skip through json stream rather than return instantly.
| { | ||
| var (jsonElementParameter, keyPropertyValuesParameter) = _jsonMaterializationContextParameterMapping[mappingParameter]; | ||
| var (jsonReaderDataParameter, keyPropertyValuesParameter) = _jsonMaterializationContextToJsonReaderDataAndKeyValuesParameterMapping[mappingParameter]; |
There was a problem hiding this comment.
here is where we actually convert from ValueBuffer based dummy property access to actual JsonReaderWriter stuff (inside CreateReadJsonPropertyValueExpression). Seems to be working fine, but idk about AOT
maumar
force-pushed
the
json_reader_sandbox_rebase
branch
from
e0b0e8c
to
9a672b6
Compare
very hacky, but most tests (apart from deduplication) work