Visit arguments in QueryableMethodNormalizingExpressionVisitor after converting List.Contains #32219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Nov 2, 2023
…converting List.Contains Fixes dotnet#32215 Fixes dotnet#32218
roji
force-pushed
the
OtherContainsFixes
branch
from
4b9280c
to
7fe11ed
Compare
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 9, 2023
…converting List.Contains (dotnet#32219) Fixes dotnet#32215 Fixes dotnet#32218 (cherry picked from commit 08ee676)
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 13, 2023
…converting List.Contains (dotnet#32219) Fixes dotnet#32215 Fixes dotnet#32218 (cherry picked from commit 08ee676)
roji
added a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BASED ON TOP OF #32214, REVIEW 2ND COMMIT ONLY@maumar QueryableMethodNormalizingExpressionVisitor.VisitMethodCall seems like it may have other bugs as well where arguments aren't visited - or double-visited. It's generally not very clear where the responsibility for recursing is in this method, we should probably clean this up to prevent further bugs like this.
Fixes #32215
Fixes #32218