[release/8.0] Visit arguments in QueryableMethodNormalizingExpressionVisitor after converting List.Contains (#32219) #32266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
added
Servicing-consider
Servicing-approved
and removed
Servicing-consider
labels
ajcvickers
approved these changes
Nov 13, 2023
…converting List.Contains (dotnet#32219) Fixes dotnet#32215 Fixes dotnet#32218 (cherry picked from commit 08ee676)
roji
force-pushed
the
OtherContainsFixes8.0
branch
from
5eee914
to
85268a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32215 and #32218, backports #32219
(cherry picked from commit 08ee676)
Description
The two bugs are fixed in the same PR as fixing the 1st exposes the 2nd.
Customer impact
The 1st bug can affect any LINQ query containins List.Contains(); if either the instance or the argument requires normalization, that normalization won't occur and query translation will likely fail. This can affect an unknown number of queries.
How found
Customer reported on 8.0
Regression
Yes.
Testing
Added tests.
Risk
Very low; separate quirks for both bugs have been added.