Set EMSDK_PYTHON=../python3 to match what emsdk_env.sh does
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the path containing the python binaries from the packages to
`PATH`, but that contains `python3`, and not `python`. When we run
`emcc --version` on a machine without a system python, it fails with
`unable to find python in $PATH`
This was not caught with our regular testing, possibly because a system
`python` was available on those machines.
`emsdk_env.sh` sets `EMSDK_PYTHON = /Users/radical/dev/r3/src/mono/wasm/emsdk/python/3.7.4-2_64bit/bin/python3`
.. so, this commit adds the same for running `emcc`, and sets that to
`python3` from the package.
This was tested on macOS.
lewing
reviewed
May 19, 2021
Only setting re:offsets tool, what's that? |
|
btw, |
akoeplinger
reviewed
May 20, 2021
akoeplinger
approved these changes
May 20, 2021
|
Ok, please open a PR for the branch then (we don't have a bot here so you'll need to do it manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the path containing the python binaries from the packages to
PATH, but that containspython3, and notpython. When we runemcc --versionon a machine without a system python, it fails withThis was not caught with our regular testing, possibly because a system
pythonwas available on those machines.emsdk_env.shsetsEMSDK_PYTHON = /Users/radical/dev/r3/src/mono/wasm/emsdk/python/3.7.4-2_64bit/bin/python3.. so, this commit adds the same for running
emcc, and sets that topython3from the package.This was tested on macOS.