Only sign and publish once at the join point #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
approved these changes
Mar 20, 2024
akoeplinger
approved these changes
Mar 20, 2024
akoeplinger
approved these changes
Mar 20, 2024
|
@mmitche that's a dotnet/runtime build and the failure is dotnet/runtime#53420 |
lewing
approved these changes
Mar 20, 2024
doh https://dev.azure.com/dnceng/internal/_build/results?buildId=2409997&view=results |
dkurepa
pushed a commit
to dkurepa/emsdk
that referenced
this pull request
Mar 21, 2024
* Only run publish at join point (dotnet#714) (cherry picked from commit 1ed00a9) * Only sign and publish once * Set asset manifest file name
mmitche
added a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the artifacts are present, so we only need to sign once