Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support netcoreapp3.1 TFM #2336

Merged
merged 11 commits into from
Sep 13, 2019
Merged

Support netcoreapp3.1 TFM #2336

merged 11 commits into from
Sep 13, 2019

Conversation

JunTaoLuo
Copy link

Pilchie
Pilchie approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see $(DefaultNetCoreTargetFramework) used in the csproj's for the refs though.

src/Caching/Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj Show resolved Hide resolved
src/Caching/Abstractions/ref/Microsoft.Extensions.Caching.Abstractions.csproj Show resolved Hide resolved
@JunTaoLuo
Copy link
Author

cc @dougbu for review.

@JunTaoLuo JunTaoLuo mentioned this pull request Sep 12, 2019
Closed
dougbu
dougbu approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nice-to-haves but that's all I caught

eng/targets/ReferenceAssembly.targets Show resolved Hide resolved
eng/tools/BaselineGenerator/BaselineGenerator.csproj Show resolved Hide resolved
src/Shared/src/BenchmarkRunner/DefaultCoreConfig.cs Show resolved Hide resolved
@JunTaoLuo JunTaoLuo merged commit 32cc816 into release/3.1 Sep 13, 2019
@ghost ghost deleted the johluo/3.1 branch September 13, 2019 05:34
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
a9b82fa 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding
\n\nCommit migrated from dotnet/extensions@32cc816
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
fd2033e 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding
\n\nCommit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
c521453 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
115b476 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
f1d53c6 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
151770c 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
f6ceac1 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
d528d93 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/performance that referenced this pull request Apr 3, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0afd56b 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Apr 13, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0173e3e 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
maryamariyan pushed a commit to maryamariyan/performance that referenced this pull request Apr 17, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
38c16cc 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
adamsitnik added a commit to dotnet/performance that referenced this pull request Jun 23, 2020
@maryamariyan @pakrym
@ryanbrandenburg @natemcmaster @benaadams @sharwell @adamsitnik
Adds Microsoft.Extensions.* performance tests with history (#1362)
1a40f0f 
* Reorganize source code

In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.


Commit migrated from dotnet/extensions@7ce647c

* Merge branch 'release/2.1' into release/2.2


Commit migrated from dotnet/extensions@18fcffb

* Merge branch 'release/2.2'


Commit migrated from dotnet/extensions@34204b6

* Reorganize source code in preparation to move into aspnet/Extensions

Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/7a283947c231b6585c8ac95e653950b660f3da96


Commit migrated from dotnet/extensions@689c4a8

* Reorganize source code in preparation to move into aspnet/Extensions

Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/12eef5e86e965b9611221c72c169002e6f3038ee


Commit migrated from dotnet/extensions@04e957b

* Reorganize source code in preparation to move into aspnet/Extensions

Prior to reorganization, this source code was found in https://github.com/aspnet/DependencyInjection/tree/d77b090567a1e6ad9a5bb5fd05f4bdcf281d4185


Commit migrated from dotnet/extensions@9a4c61b

* Reorganize source code in preparation to move into aspnet/Extensions

Prior to reorganization, this source code was found in https://github.com/aspnet/Logging/tree/f7d8e4e0537eaab54dcf28c2b148b82688a3d62d


Commit migrated from dotnet/extensions@f3cd14a

* Reorganize source code in preparation to move into aspnet/Extensions

Prior to reorganization, this source code was found in https://github.com/aspnet/HttpClientFactory/tree/cf7cf83ee869ed50a41852f5e880d073386b7fe7


Commit migrated from dotnet/extensions@c38f9c1

* Use the SharedSourceRoot variable in project files


Commit migrated from dotnet/extensions@888bcba

* Allow caching of IEnumerable services (dotnet/extensions#575)



Commit migrated from dotnet/extensions@c89a5b5

* Reduce event source logger allocations (dotnet/extensions#870)



Commit migrated from dotnet/extensions@091ee13

* Use Arcade (dotnet/extensions#586)

Use arcade


Commit migrated from dotnet/extensions@f045899

* Cleanup conversion to Arcade (dotnet/extensions#1014)

* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel


Commit migrated from dotnet/extensions@f41cfde

* Shrink StringValues (dotnet/extensions#1283)



Commit migrated from dotnet/extensions@2f8e1fb

* Disable transitive project references in test projects (dotnet/extensions#1834)



Commit migrated from dotnet/extensions@e7d5bea

* Fix HTTP client benchmarks


Commit migrated from dotnet/extensions@8f0f7fa

* Add typed client creation benchmark


Commit migrated from dotnet/extensions@20ce03a

* Support netcoreapp3.1 TFM (dotnet/extensions#2336)

* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816

* Normalize all file headers to the expected Apache 2.0 license


Commit migrated from dotnet/extensions@cec6e75

* Switch file headers to the MIT license


Commit migrated from dotnet/extensions@321a30c

* Moves Microsoft.Extensions.* perf tests over

* Using the Open key to fully sign assembly

- Needed to later get InternalsVisibleTo on DI

* Apply suggestions from code review

Make batch commit using suggestions in PR feedback

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>

* Fix compile + other feedback

* Apply suggestions from code review

Co-authored-by: Nate McMaster <nate.mcmaster@microsoft.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Ryan Brandenburg <rybrande@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ryan Nowak <rynowak@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
6af6e78 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding
\n\nCommit migrated from dotnet/extensions@32cc816
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tratcher Tratcher Tratcher left review comments

@Pilchie Pilchie Pilchie approved these changes

@dougbu dougbu dougbu approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JunTaoLuo @Pilchie @Tratcher @dougbu