Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Microsoft.Extensions.* performance tests with history #1362

Merged
merged 33 commits into from
Jun 23, 2020

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Jun 17, 2020

Nate McMaster and others added 29 commits October 30, 2018 14:18
In preparation for merging many other projects into this repo, this establishes a new source code organization which groups projects together based on subject matter.


Commit migrated from dotnet/extensions@7ce647c
This includes the master branch of aspnet/HttpClientFactory


Commit migrated from dotnet/extensions@557995e
* Remove obsolete targets, properties, and scripts
* Replace IsProductComponent with IsShipping
* Undo bad merge to version.props
* Update documentation, and put workarounds into a common file
* Replace usages of RepositoryRoot with RepoRoot
* Remove API baselines
* Remove unnecessary restore feeds and split workarounds into two files
* Enable PR checks on all branches, and disable autocancel


Commit migrated from dotnet/extensions@f41cfde
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
- Needed to later get InternalsVisibleTo on DI
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryamariyan big thanks for porting all these benchmarks to the performance repo!

the porting itself looks very good, however, I have some comments related to the benchmarks themselves. Before we merge them we should make sure that they follow our guidelines

As soon as all suggestions are applied, I am going to merge this PR.

Once again big thanks for all the work @maryamariyan ! It took me a few hours to review it, I can imagine how long it took to actually port them!

Make batch commit using suggestions in PR feedback

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
@maryamariyan
Copy link
Member Author

maryamariyan commented Jun 22, 2020

@adamsitnik ready for re-review.
Aside from comments #1362 (comment) and #1362 (comment), I applied the rest of them. Thanks for making it easy with those commit batch suggestions :)

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maryamariyan !

@adamsitnik
Copy link
Member

adamsitnik commented Jun 23, 2020

One of the CI legs failed with a really strange error:

 --------------------------------------------------
 Building .NET micro benchmarks for 'netcoreapp5.0'
 --------------------------------------------------
 $ pushd "C:\h\w\AB6A0982\p\src\benchmarks\micro"
 $ dotnet build C:\h\w\AB6A0982\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\AB6A0982\p\artifacts\packages
 Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
 Copyright (C) Microsoft Corporation. All rights reserved.
 
 C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
 
 Build FAILED.
 
 C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\AB6A0982\p\tools\dotnet\x86\sdk\5.0.100-preview.7.20318.12\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\AB6A0982\p\src\tools\Reporting\Reporting\Reporting.csproj]
     0 Warning(s)
     1 Error(s)

I am going to re-run it.

Edit: I can see exactly same error in #1372 so it's not related to this PR

@adamsitnik adamsitnik merged commit 1a40f0f into dotnet:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants