Readme for Microsoft.Extensions.Http.Diagnostics #4674
Conversation
xakep139
requested review from
ananthsr,
CarnaViire,
dariusclay,
omsoftdev,
iliar-turdushev and
geeknoid
|
|
||
| These components enable enriching and redacting HTTP Client request logs. They remove built-it HTTP Client logging. | ||
|
|
||
| In order to use the redaction feature, you need to reference the `Microsoft.Extensions.Compliance.Redaction` package. |
There was a problem hiding this comment.
This is non-trivial and we need to improve discoverability of this (reference redaction package in Http.Diagnostics package?). I will create a work item to track that
There was a problem hiding this comment.
Yeah I think we should reference the Redaction package automatically. Even when it is not used directly, the idea would be for folks referencing this package to be able to look at your sample code from the README and use it, but if we don't include the package reference they would get an error in the call to AddRedaction.
There was a problem hiding this comment.
That said, I agree with you we can fix this in a separate change.
| builder.Services.AddRedaction(); | ||
|
|
||
| // Register latency context services: | ||
| builder.Services.AddLatencyContext(); |
There was a problem hiding this comment.
This was also non-trivial as DI simply throws an exception if I forget to add this line. We definitely need to improve this.
There was a problem hiding this comment.
Tracked under #4675
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
|
@joperezr do we still merge PRs into |
null
Microsoft Reviewers: Open in CodeFlow