Simplify platform check. #4853
Merged
Simplify platform check. #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
xakep139
reviewed
Jan 5, 2024
| @@ -62,7 +62,7 @@ public static class ResourceMonitoringServiceCollectionExtensions | |||
| #if NETFRAMEWORK | |||
| _ = builder.AddWindowsProvider(); | |||
| #else | |||
| if (GetPlatform() == PlatformID.Win32NT) | |||
| if (OperatingSystem.IsWindows()) | |||
There was a problem hiding this comment.
In that case we need to check whether else clause falls under IsLinux() - and throw an exception otherwise
geeknoid
force-pushed
the
geeknoid/plat
branch
from
afba67c
to
a620241
Compare
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=516960&view=codecoverage-tab |
RussKie
approved these changes
Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4642
Microsoft Reviewers: Open in CodeFlow