Add Compaction logging #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Nov 15, 2018
| @@ -553,7 +553,7 @@ public void AddAndReplaceEntries_AreThreadSafe() | |||
| var entrySize = random.Next(0, 5); | |||
| cache.Set(random.Next(0, 10), entrySize, new MemoryCacheEntryOptions { Size = entrySize }); | |||
| } | |||
| }, cts.Token); | |||
There was a problem hiding this comment.
We don't need to pass the token since we check via cts.IsCancellationRequested inside the tasks. Alternatively we can catch the TaskCancelledException from WaitAll
Tratcher
requested changes
Nov 15, 2018
src/Caching/Memory/src/Microsoft.Extensions.Caching.Memory.csproj
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
Nov 16, 2018
|
Just out of curiosity: Why is the memory cache injecting a |
natemcmaster
pushed a commit
that referenced
this pull request
Nov 21, 2018
…master [automated] Merge branch 'release/2.2' => 'master'
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe Commit migrated from dotnet/extensions@c3c9c55
JunTaoLuo
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
* Add logging for compaction test * Fix AddAndReplaceEntries_AreThreadSafe \n\nCommit migrated from dotnet/extensions@c3c9c55
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening aspnet/Caching#441 in the right repo.
Adding logging to test out my theory on aspnet/Caching#429.
Also fixing a test for https://github.com/aspnet/AspNetCore-Internal/issues/1374.