Test failure: DoNotAddIfSizeOverflows

[ryanbrandenburg]

This issue was made automatically. If there is a problem contact ryanbrandenburg.

This test failed with the following error:

Assert.True() Failure
Expected: True
Actual:   False

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.

This test failed on master.

CC @Eilon

[ryanbrandenburg]

This comment was made automatically. If there is a problem contact ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

• Is this actually a flaky test?

  • No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
  • Yes, proceed below...

• Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

  • File a bug against the product (TODO: Link to other bug)
  • Is it possible to change the test to avoid the flakiness?
    • Yes? Go to the "Change the test!" section.
    • No?
      • Disable the test (TODO: Link to PR/commit)
      • Wait for other bug to be resolved
      • Wait for us to get build that has the fix
      • Re-enable our test (TODO: Link to PR/commit)
      • Close this bug

• Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

  • Is there is a way to change our test to avoid this flakiness?
    • Yes? Change the test!
      • Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
      • Run the test 100 times locally as a sanity check.
      • Close this bug
    • No?
      • Is there any logging or extra information that we could add to make this more diagnosable when it happens again?
        • Yes?
          • Add the logging (TODO: Link to PR/commit)
        • No?
          • Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

[Eilon]

@muratg - all yours.

[muratg]

@JunTaoLuo can you take a look? Any changes which may have caused this?

[aspnet-hello]

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on release/2.2 at 10:51:43 PM:

• DoNotAddIfSizeOverflows

[JunTaoLuo]

Hmm I'm not certain what's going on here but we never had these tests fail on teamcity. I can't reproduce these locally either so it's hard to say if it's a product issue or test issue. To diagnose this issue properly, we might need to end up implementing https://github.com/aspnet/Caching/issues/261 which could be somewhat involved.

From a quick look, the compaction is executed on the thread pool so my current theory would be that the compaction isn't being run due to starvation. I'd like to add an option to run the compaction inline for tests and see if the tests are fixed.

[JunTaoLuo]

It also looks like this test is only failing on VSTS. There were no failures on teamcity: http://aspnetci/project.html?projectId=AspNetEf&buildTypeId=&tab=testDetails&testNameId=6648551514755003340&order=START_DATE_DESC&branch_AspNetEf=__all_branches__&itemsCount=50. I know we are migrating to VSTS now but the history on teamcity is informative.

[JunTaoLuo]

Logging added

[JunTaoLuo]

Closing. Tracking future failures in new issues filed by RaaS.