Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intellisense does not appear off of generic type #8

Closed
KevinRansom opened this issue Jan 14, 2015 · 5 comments
Closed

Intellisense does not appear off of generic type #8

KevinRansom opened this issue Jan 14, 2015 · 5 comments
Labels
Bug Regression

Comments

@KevinRansom
Copy link
Member

Opened by: latkin

In the below code, intellisense no longer pops up at the specified point. It used to work ok in 3.1.X, but has stopped working in 4.0

type GT<'a> =
  static member P = 12
  static member Q = 13

let _ = GT<int>. <--- no intellisense here now, expecting list with 'P','Q'
let _ = GT.   <---- intellisense does still appear here

Testing it out on some older builds, this appears to have been introduced with the "constructors as first-class functions" feature.

comments

dsyme wrote Dec 11, 2014 at 1:35 PM [x]

What's the name of the specific IDE unit test that's failing? I'll aim to run them and make the fix tomorrow

latkin wrote Dec 11, 2014 at 2:12 PM [x]
UnitTests.Tests.LanguageService.AutoCompletionListTests, testcase Generics.GenericTypeMembers

latkin wrote Dec 11, 2014 at 2:30 PM [x]
Note that you'll need a build of VS 2015, plus the VS 2015 SDK, installed to run the IDE tests for fsharp4. You can get both from here http://www.visualstudio.com/en-us/downloads/visual-studio-2015-downloads-vs.aspx
@latkin
Copy link
Contributor

latkin commented Jan 21, 2015

@dsyme this regressed (I'm pretty sure) as part of the "ctors as first-class functions" work.

@dsyme dsyme self-assigned this Jan 21, 2015
@dsyme
Copy link
Contributor

dsyme commented Jan 21, 2015

Have assigned it to myself

@vladima vladima mentioned this issue Feb 6, 2015
Closed
@KevinRansom
Copy link
Member Author

Don,
is there any progress on this? It is a regression and so it is one we would prefer to have a fix for when we release F# 4.0

@dsyme
Copy link
Contributor

dsyme commented Mar 23, 2015

I've looked at it several times and not found the mistake. I'll keep looking :)

dsyme referenced this issue in dsyme/fsharp Apr 9, 2015
@dsyme
potential fix for #8
67d4d7f
dsyme referenced this issue in dsyme/fsharp Apr 9, 2015
@dsyme
potential fix for #8 (2)
1776403
@dsyme dsyme mentioned this issue Apr 9, 2015
Closed
@dsyme
Copy link
Contributor

dsyme commented Apr 9, 2015

I made my third attempt on this and finally got somewhere. It was hard! At least I now understand what changed between F# 3.1 and F# 4.0 and have prepared a potential fix. #354

I'd appreciate help in testing if the fix works "for real" in intellisense in VS2015. I've tried to make the fix as non-intrusive and low-risk as possible (even though that involved duplicating some code).

@dsyme dsyme closed this as completed in 5447cd2 Apr 11, 2015
@latkin latkin added the fixed label Apr 11, 2015
KevinRansom pushed a commit that referenced this issue Jul 27, 2016
@dsyme
Merge pull request #8 from KevinRansom/dsyme-tuple-spike
875bdff 
Dsyme tuple spike
liboz pushed a commit to liboz/visualfsharp that referenced this issue Oct 15, 2016
@manofstick
Merge pull request dotnet#8 from liboz/manofstick
15b14a1 
Seq.zip(3)?
nelak pushed a commit to nelak/visualfsharp that referenced this issue Nov 20, 2016
@AviAvni
Merge pull request dotnet#8 from Microsoft/master
500c342 
merge from dev
cartermp added a commit to cartermp/fsharp that referenced this issue Jan 7, 2020
@cartermp
# This is a combination of 9 commits.
3ae2127 
# This is the 1st commit message:

ref -> mutable in more places in the compiler

# The commit message dotnet#2 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191229.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1

# The commit message dotnet#3 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191230.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19630.1

# The commit message dotnet#4 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191231.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19631.1

# The commit message dotnet#5 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20200101.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20051.1

# The commit message dotnet#6 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191216.5 (dotnet#8079)
#
# - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19616.5

# The commit message dotnet#7 will be skipped:

# dispose fsi at the end of a scripting session (dotnet#8084)
#

# The commit message dotnet#8 will be skipped:

# Added static link tests and extended CompilerAssert (dotnet#8101)
#
# * Changed CompilerAssert to static class. Added Compile/Execute methods that take a Compilation description. Added static link tests
# 
# * Hiding compilation description internals
# 
# * Added another test to check for sanity
# 
# * Making a few optional parameters
# 
# * Hiding internals of CompilationReference

# The commit message dotnet#9 will be skipped:

# Parameterize product version (dotnet#8031)
#
# * Parameterize Product details
# 
# * fcs
# 
# * Repack pkgdef
cartermp added a commit that referenced this issue Jan 7, 2020
@cartermp
Replace (nearly) all ref cells in the compiler with mutable values (#…
f9ea582 
…8063)

* # This is a combination of 9 commits.
# This is the 1st commit message:

ref -> mutable in more places in the compiler

# The commit message #2 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191229.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1

# The commit message #3 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191230.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19630.1

# The commit message #4 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191231.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19631.1

# The commit message #5 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20200101.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20051.1

# The commit message #6 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191216.5 (#8079)
#
# - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19616.5

# The commit message #7 will be skipped:

# dispose fsi at the end of a scripting session (#8084)
#

# The commit message #8 will be skipped:

# Added static link tests and extended CompilerAssert (#8101)
#
# * Changed CompilerAssert to static class. Added Compile/Execute methods that take a Compilation description. Added static link tests
# 
# * Hiding compilation description internals
# 
# * Added another test to check for sanity
# 
# * Making a few optional parameters
# 
# * Hiding internals of CompilationReference

# The commit message #9 will be skipped:

# Parameterize product version (#8031)
#
# * Parameterize Product details
# 
# * fcs
# 
# * Repack pkgdef

* no ilread
nosami referenced this issue in xamarin/visualfsharp Feb 23, 2021
@cartermp @nosami
Replace (nearly) all ref cells in the compiler with mutable values (d…
42bc601 
…otnet#8063)

* # This is a combination of 9 commits.
# This is the 1st commit message:

ref -> mutable in more places in the compiler

# The commit message #2 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191229.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1

# The commit message #3 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191230.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19630.1

# The commit message #4 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191231.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19631.1

# The commit message #5 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20200101.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20051.1

# The commit message #6 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191216.5 (dotnet#8079)
#
# - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19616.5

# The commit message #7 will be skipped:

# dispose fsi at the end of a scripting session (dotnet#8084)
#

# The commit message #8 will be skipped:

# Added static link tests and extended CompilerAssert (dotnet#8101)
#
# * Changed CompilerAssert to static class. Added Compile/Execute methods that take a Compilation description. Added static link tests
# 
# * Hiding compilation description internals
# 
# * Added another test to check for sanity
# 
# * Making a few optional parameters
# 
# * Hiding internals of CompilationReference

# The commit message #9 will be skipped:

# Parameterize product version (dotnet#8031)
#
# * Parameterize Product details
# 
# * fcs
# 
# * Repack pkgdef

* no ilread
vzarytovskii referenced this issue in vzarytovskii/fsharp Aug 17, 2023
@vzarytovskii
Final (?) tests fixes #8, pretty please with cherry on top, please ha…
1a6d162 
…ve mercy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KevinRansom @latkin @dsyme