-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS 16.5.1 causes FS1153 Invalid floating point number #8802
Comments
Thanks for the report @smoothdeveloper. I can't reproduce this with the .NET 5 preview compiler (should be the same bits as 16.5? Could be wrong though...). Though I did note that
|
Tagging as |
@cartermp @smoothdeveloper, I don't see this with 3.1.200 of the dotnet sdk, or the desktop compiler version 10.8.0.0 for F# 4.7. It is also worth noting that no servicing changes happened for F# in 16.5.1 |
However, fsi:
|
Okay, this is due to https://github.com/dotnet/fsharp/pull/7839/files @smoothdeveloper as a quick workaround you can just set |
@smoothdeveloper just wanted to say that this might be a first: three Microsoft employees who contribute to the compiler codebase signed off on the change officially in its final form (with another who felt it was a great change midway through development). Additionally, there were no tests we could find for this case. So I think it's rather impressive that this managed to happen 😅 |
truly a bruh moment |
@cartermp my guess is that the change looked innocuous in itself, making it easier to dismiss potential issues. My take away is that anything touching literals, the lexer or involving compiler feature flag welcomes increased scrutiny. I'm glad the issue was identified and already has a fix pending, props to everyone. |
@smoothdeveloper, while we were looking at the issue, I still insisted it was a fine change. |
… dotless exponential. (dotnet#8837) * Fix dotnet#8802 (dotnet#8827) * update mac os image
The compiler version that ships with VS2019 v16.5.1 doesn't recognize number literals such as
1e-6f
.it works fine in v16.4 releases and in the 16.6 preview release so it probably is fixed already.
Related information
The text was updated successfully, but these errors were encountered: