Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reactor queue dependency removal #11109

Merged
merged 10 commits into from
Feb 22, 2021
Merged

Conversation

TIHan
Copy link
Member

@TIHan TIHan commented Feb 13, 2021

This is another change that is going to remove more cases that depend on the reactor queue. It's a little tricky as we need to make a change in incremental builder to grab cached data but also check to see if the data is still valid.

In order to make the internal state of the incremental builder sane, I created an immutable state object that contains all the necessary items such as timestamps, bound models, etc. When we need to update the state, we just update a single value, currentState. This makes it a lot easier to rationalize, especially when we want to concurrently grab info from the state.

@TIHan TIHan changed the title [WIP] More reactor queue dependency removal More reactor queue dependency removal Feb 20, 2021
@TIHan
Copy link
Member Author

TIHan commented Feb 20, 2021

This is now ready.

@cartermp cartermp merged commit 718d3c4 into dotnet:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants