More reactor queue dependency removal #11109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another change that is going to remove more cases that depend on the reactor queue. It's a little tricky as we need to make a change in incremental builder to grab cached data but also check to see if the data is still valid.
In order to make the internal state of the incremental builder sane, I created an immutable state object that contains all the necessary items such as timestamps, bound models, etc. When we need to update the state, we just update a single value,
currentState
. This makes it a lot easier to rationalize, especially when we want to concurrently grab info from the state.