Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More reactor queue dependency removal #11109

Merged
merged 10 commits into from
Feb 22, 2021
Merged

More reactor queue dependency removal #11109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f45afb
Allowing stale cached results to not call into the reactor thread if …
TIHan Feb 12, 2021
a4af72f
Cleaning up. Getting cached results should not hit the reactor thread.
TIHan Feb 13, 2021
82a75a9
Removing compilation thread token from getting logical timestamp
TIHan Feb 18, 2021
36b9abb
Added IncrementalBuilderState record
TIHan Feb 19, 2021
72d7b9c
Added enablePartialTypeChecking to the state
TIHan Feb 19, 2021
1d353c3
quick change
TIHan Feb 19, 2021
4980ee9
Trying to fix state
TIHan Feb 19, 2021
a8123e3
minor cleanup
TIHan Feb 19, 2021
863439b
Try to get check results if it is up-to-date
TIHan Feb 20, 2021
c2846cb
Checking up-to-date
TIHan Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fsharp/CompilerConfig.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ type TimeStampCache(defaultTimeStamp: DateTime) =
files.[fileName] <- v
v

member cache.GetProjectReferenceTimeStamp (pr: IProjectReference, ctok) =
member cache.GetProjectReferenceTimeStamp (pr: IProjectReference) =
let ok, v = projects.TryGetValue pr
if ok then v else
let v = defaultArg (pr.TryGetLogicalTimeStamp (cache, ctok)) defaultTimeStamp
let v = defaultArg (pr.TryGetLogicalTimeStamp (cache)) defaultTimeStamp
projects.[pr] <- v
v

Expand All @@ -215,7 +215,7 @@ and IProjectReference =
///
/// The operation returns None only if it is not possible to create an IncrementalBuilder for the project at all, e.g. if there
/// are fatal errors in the options for the project.
abstract TryGetLogicalTimeStamp: TimeStampCache * CompilationThreadToken -> System.DateTime option
abstract TryGetLogicalTimeStamp: TimeStampCache -> System.DateTime option

type AssemblyReference =
| AssemblyReference of range * string * IProjectReference option
Expand Down
4 changes: 2 additions & 2 deletions src/fsharp/CompilerConfig.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type IRawFSharpAssemblyData =
type TimeStampCache =
new: defaultTimeStamp: DateTime -> TimeStampCache
member GetFileTimeStamp: string -> DateTime
member GetProjectReferenceTimeStamp: IProjectReference * CompilationThreadToken -> DateTime
member GetProjectReferenceTimeStamp: IProjectReference -> DateTime

and IProjectReference =

Expand All @@ -76,7 +76,7 @@ and IProjectReference =
///
/// The operation returns None only if it is not possible to create an IncrementalBuilder for the project at all, e.g. if there
/// are fatal errors in the options for the project.
abstract TryGetLogicalTimeStamp: TimeStampCache * CompilationThreadToken -> System.DateTime option
abstract TryGetLogicalTimeStamp: TimeStampCache -> System.DateTime option

type AssemblyReference =
| AssemblyReference of range * string * IProjectReference option
Expand Down
Loading