-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable implicit FSharp.Core and System.ValueTuple when using Central Package Management #13920
Disable implicit FSharp.Core and System.ValueTuple when using Central Package Management #13920
Conversation
Hello! How can these changes be tested? |
Good question, not sure if we have an automated way of testing it this kind of change. cc @KevinRansom - we need to support CPVM, since it's stable now and more projects are using it. Is this the desired solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, there is one extra property that needs to be set:
DisableImplicitSystemValueTupleReference
but other than that this looks fine.
Adding DisableImplicitSystemValueTupleReference Also, I think that we can use a workaround, by setting DisableImplicitLibraryPacksFolder |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
… Package Management
fd9a8c8
Pull request was closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. There is an open conversation but looks like there is some consensus. Can we merge this?
https://devblogs.microsoft.com/nuget/introducing-central-package-management/
DisableImplicitLibraryPacksFolder = true
because it is necessary to map source packages when using Central Package Management