Disable implicit FSharp.Core and System.ValueTuple when using Central Package Management #13920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! How can these changes be tested? |
rstm-sf
commented
Sep 19, 2022
rstm-sf
force-pushed
the
infra/Central_Package_Management
branch
from
404a186
to
50cd836
Compare
Good question, not sure if we have an automated way of testing it this kind of change. cc @KevinRansom - we need to support CPVM, since it's stable now and more projects are using it. Is this the desired solution? |
KevinRansom
requested changes
Sep 19, 2022
baronfel
reviewed
Sep 19, 2022
rstm-sf
force-pushed
the
infra/Central_Package_Management
branch
from
50cd836
to
e4724d1
Compare
rstm-sf
changed the title
|
Adding DisableImplicitSystemValueTupleReference Also, I think that we can use a workaround, by setting DisableImplicitLibraryPacksFolder |
rstm-sf
force-pushed
the
infra/Central_Package_Management
branch
from
e4724d1
to
cebb3ce
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vzarytovskii
previously approved these changes
Oct 6, 2022
KevinRansom
previously approved these changes
Oct 7, 2022
… Package Management
rstm-sf
dismissed stale reviews from KevinRansom and vzarytovskii
via
fd9a8c8
rstm-sf
force-pushed
the
infra/Central_Package_Management
branch
from
ab3bd2a
to
fd9a8c8
Compare
auto-merge was automatically disabled
November 6, 2022 20:09
Pull request was closed
vzarytovskii
approved these changes
Nov 6, 2022
T-Gro
approved these changes
Nov 7, 2022
psfinaki
approved these changes
Nov 7, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devblogs.microsoft.com/nuget/introducing-central-package-management/
DisableImplicitLibraryPacksFolder = truebecause it is necessary to map source packages when using Central Package Management