Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncLocal part 2 - replace all ThreadStatics and remove NodeCode and node CE #16645

Closed
wants to merge 29 commits into from

Merge branch 'main' into asynclocal

5addd4f
Select commit
Loading
Failed to load commit list.
Closed

AsyncLocal part 2 - replace all ThreadStatics and remove NodeCode and node CE #16645

Merge branch 'main' into asynclocal
5addd4f
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Feb 12, 2024 in 1h 16m 33s

Build #20240212.30 had test failures

Details

Tests

  • Failed: 1 (0.00%)
  • Passed: 58,045 (97.77%)
  • Other: 1,321 (2.23%)
  • Total: 59,367

Annotations

Check failure on line 82744 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L82744

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 82745 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L82745

Cmd.exe exited with code '1'.

Check failure on line 1 in FSharp.Compiler.UnitTests.FsiTests.Creation of a bound value fails if the name is whitespace

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

FSharp.Compiler.UnitTests.FsiTests.Creation of a bound value fails if the name is whitespace

System.Exception : Error creating evaluation session: System.AggregateException: One or more errors occurred. (Value cannot be null.)
 ---> System.ArgumentNullException: Value cannot be null.
   at System.Threading.Monitor.Enter(Object obj)
   at FSharp.Compiler.AbstractIL.IL.ILPreTypeDefImpl.FSharp.Compiler.AbstractIL.IL.ILPreTypeDef.GetTypeDef() in D:\a\_work\1\s\src\Compiler\AbstractIL\il.fs:line 2881
   at FSharp.Compiler.Import.entities@548-1.Invoke(Tuple`2 tupledArg) in D:\a\_work\1\s\src\Compiler\Checking\import.fs:line 550
   at FSharp.Compiler.Import.multisetDiscriminateAndMap[Key,Value,a](FSharpFunc`2 nodef, FSharpFunc`2 tipf, FSharpList`1 items) in D:\a\_work\1\s\src\Compiler\Checking\import.fs:line 510
   at FSharp.Compiler.Import.ImportILTypeDefList(FSharpFunc`2 amap, Range m, CompilationPath cpath, FSharpList`1 enc, FSharpList`1 items) in D:\a\_work\1\s\src\Compiler\Checking\import.fs:line 543
   at FSharp.Compiler.Import.modty@546.Invoke(Unit _arg2) in D:\a\_work\1\s\src\Compiler\Checking\import.fs:line 546
   at Internal.Utilities.Library.InterruptibleLazy`1.get_Value() in D:\a\_work\1\s\src\Compiler\Utilities\illib.fs:line 39
   at Internal.Utilities.Library.Extras.MaybeLazy`1.Force() in D:\a\_work\1\s\src\Compiler\Utilities\lib.fs:line 396
   at FSharp.Compiler.CompilerImports.TcImports.ccuHasType(CcuThunk ccu, FSharpList`1 nsname, String tname, Boolean publicOnly) in D:\a\_work\1\s\src\Compiler\Driver\CompilerImports.fs:line 1202
   at FSharp.Compiler.CompilerImports.tryFindSysTypeCcu@2508-1.Invoke(CcuThunk ccu) in D:\a\_work\1\s\src\Compiler\Driver\CompilerImports.fs:line 2508
   at Microsoft.FSharp.Collections.ArrayModule.loop@1129-40[T](FSharpFunc`2 predicate, T[] array, Int32 i) in D:\a\_work\1\s\src\FSharp.Core\array.fs:line 1132
   at Microsoft.FSharp.Collections.ArrayModule.TryFind[T](FSharpFunc`2 predicate, T[] array) in D:\a\_work\1\s\src\FSharp.Core\array.fs:line 1137
   at FSharp.Compiler.TcGlobals.TcGlobals.tryFindSysTypeCcu(FSharpList`1 path, String nm) in D:\a\_work\1\s\src\Compiler\TypedTree\TcGlobals.fs:line 214
   at FSharp.Compiler.TcGlobals.TcGlobals.findSysTypeCcu(FSharpList`1 path, String typeName) in D:\a\_work\1\s\src\Compiler\TypedTree\TcGlobals.fs:line 285
   at FSharp.Compiler.TcGlobals.TcGlobals.findSysTyconRef(FSharpList`1 path, String nm) in D:\a\_work\1\s\src\Compiler\TypedTree\TcGlobals.fs:line 296
   at FSharp.Compiler.TcGlobals.TcGlobals..ctor(Boolean compilingFSharpCore, ILGlobals ilg, CcuThunk fslibCcu, String directoryToResolveRelativePaths, Boolean mlCompatibility, Boolean isInteractive, Boolean useReflectionFreeCodeGen, FSharpFunc`2 tryFindSysTypeCcuHelper, Boolean emitDebugInfoInQuotations, Boolean noDebugAttributes, PathMap pathMap, LanguageVersion langVersion) in D:\a\_work\1\s\src\Compiler\TypedTree\TcGlobals.fs:line 381
   at FSharp.Compiler.CompilerImports.BuildFrameworkTcImports@2501-10.Invoke(FSharpList`1 _arg11) in D:\a\_work\1\s\src\Compiler\Driver\CompilerImports.fs:line 2514
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, b result1, FSharpFunc`2 userCode) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 528
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112
   --- End of inner exception stack trace ---
   at FSharp.Compiler.BuildGraph.Async.RunImmediateWithoutCancellation[T](FSharpAsync`1 computation) in D:\a\_work\1\s\src\Compiler\Facilities\BuildGraph.fs:line 29
   at FSharp.Compiler.Interactive.Shell.FsiEvaluationSession..ctor(FsiEvaluationSessionHostConfig fsi, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, Boolean fsiCollectible, FSharpOption`1 legacyReferenceResolver) in D:\a\_work\1\s\src\Compiler\Interactive\fsi.fs:line 4596
Raw output
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1448.Invoke(String message)
   at FSharp.Compiler.Interactive.Shell.FsiEvaluationSession..ctor(FsiEvaluationSessionHostConfig fsi, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, Boolean fsiCollectible, FSharpOption`1 legacyReferenceResolver) in D:\a\_work\1\s\src\Compiler\Interactive\fsi.fs:line 4600
   at FSharp.Compiler.Interactive.Shell.FsiEvaluationSession.Create(FsiEvaluationSessionHostConfig fsiConfig, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, FSharpOption`1 collectible, FSharpOption`1 legacyReferenceResolver) in D:\a\_work\1\s\src\Compiler\Interactive\fsi.fs:line 4931
   at FSharp.Compiler.UnitTests.FsiTests.createFsiSession(Boolean useOneDynamicAssembly) in D:\a\_work\1\s\tests\FSharp.Compiler.UnitTests\FsiTests.fs:line 31
   at FSharp.Compiler.UnitTests.FsiTests.Creation of a bound value fails if the name is whitespace() in D:\a\_work\1\s\tests\FSharp.Compiler.UnitTests\FsiTests.fs:line 340
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)