Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension for property initializers #17

Closed
wants to merge 6 commits into from

Conversation

forki
Copy link
Contributor

@forki forki commented Jan 15, 2015

This implements support for extension properties setters in initializers as described UserVoice: http://fslang.uservoice.com/forums/245727-f-language/suggestions/6200089-allow-extension-properties-setters-in-initializers

It was originally submited by Edward Paul (@xepaul) at https://visualfsharp.codeplex.com/SourceControl/network/forks/EdwardPaul/PropertyInitializationExperiments/contribution/7391

Latkin: F# 4.0 triage -- This PR is approved in principle for F# 4.0.
If remaining issues can be addressed by 1/16 it will be included in F# 4.0.
Otherwise it will be considered for the next release.
AFAIK @EdwardPaul has fixed the known issues and just needs to clean up the build.

As the deadline is tomorrow I wanted to step in and rebased this on current fsharp4 branch

match styling change.
added open module to remove fully qualified path
removed unnecessary comment  "//need to hide"  added during prototyping
@forki forki changed the title Extension for property initializers WIP: Extension for property initializers Jan 15, 2015
@dsyme
Copy link
Contributor

dsyme commented Jan 15, 2015

Great! I've updated the link on the status page to point to this one

@forki
Copy link
Contributor Author

forki commented Jan 15, 2015

I still need to fix the build.

@forki forki changed the title WIP: Extension for property initializers Extension for property initializers Jan 15, 2015
@forki
Copy link
Contributor Author

forki commented Jan 15, 2015

I fixed the build and tests. (verified against #15)

@xepaul could you please review cbf4d76?

@dsyme
Copy link
Contributor

dsyme commented Jan 15, 2015

@forki I've checked it - it is fine.

@latkin
Copy link
Contributor

latkin commented Jan 15, 2015

Thanks for taking this and getting it in shape. Looks good to me, issues all seem to be resolved now.

I will merge it in a minute, hopefully I have the comment right so that it closes properly here.

@latkin latkin closed this in d9348ec Jan 15, 2015
@xepaul
Copy link
Contributor

xepaul commented Jan 15, 2015

Thanks, this is great, it looks good, although regrettably I'm having system setup issues at the moment so I can't see it running.

liboz pushed a commit to liboz/visualfsharp that referenced this pull request Oct 22, 2016
fix bug where unfold did not respect the Halted state on Result
KevinRansom pushed a commit to KevinRansom/fsharp that referenced this pull request May 26, 2018
nojaf pushed a commit to nojaf/fsharp that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants