Retarget to .NET 5.0 #273
Merged
Retarget to .NET 5.0 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant2002
force-pushed
the
kant/net50
branch
3 times, most recently
from
d1811ea
to
aec9f9d
Compare
|
/cc @tminka |
|
Could be updated to .NET 6 now too, to get even more perf goodness for (almost) free. |
|
Please update the branch and re-run the checks. They should pass now. |
Gladly. |
Since there RC1 builds popping up, and in my experience .NET 5.0 is stable update over .NET 3.1 it may be interested to start testing this on .NET 5.0
|
@tminka while I have a bit of your attention, can I ask couple questions?
|
|
It seems best to have one commit that corresponds to .NET 5, and another one that corresponds to .NET 6, so that it is possible for anyone to get the appropriate version from the git history. I'm not familiar with what is needed for AOT. There haven't been any requests for it. |
|
Thanks!! I was looking at this project and cannot spot the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to .NET 5.0
This brings a lot of performance improvements to the solution.