Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime and aspnetcore patches to always build libs, app.ref and targetting packs #13009

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add runtime and aspnetcore patches to always build libs, app.ref and targetting packs #13009

merged 2 commits into from
Jan 19, 2022

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons
Copy link
Member Author

The failing bootstrap build in CI is tracked with dotnet/aspnetcore#39471.

@MichaelSimons MichaelSimons marked this pull request as ready for review January 13, 2022 00:37
@MichaelSimons MichaelSimons requested a review from a team as a code owner January 13, 2022 00:37
@MichaelSimons MichaelSimons changed the title Add runtime patch to build all packages during source-build Add runtime and aspnetcore patches to always build libs, app.ref and targetting packs Jan 18, 2022
@MichaelSimons MichaelSimons marked this pull request as draft January 18, 2022 16:33
@MichaelSimons MichaelSimons mentioned this pull request Jan 18, 2022
Closed
@MichaelSimons MichaelSimons marked this pull request as ready for review January 18, 2022 21:08
@dougbu
Copy link
Member

dougbu commented Jan 18, 2022

The failing bootstrap build in CI

What does "failing bootstrap" mean❔ Is this a warning somewhere in the CI checks for this PR❔ (Too much noise for me to see a new warning.)

dougbu
dougbu approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me as long as WindowsDesktop will also provide a patch and @safern is speaking for dotnet/runtime

@dougbu dougbu requested a review from safern January 18, 2022 21:42
@MichaelSimons
Copy link
Member Author

This works for me as long as WindowsDesktop will also provide a patch and @safern is speaking for dotnet/runtime

WindowsDesktop is not part of source-build so a patch is not needed. The runtime fix was already checked in and this proactively pulling the fix into source-build until it flows in.

@MichaelSimons
Copy link
Member Author

What does "failing bootstrap" mean❔ Is this a warning somewhere in the CI checks for this PR❔ (Too much noise for me to see a new warning.)

This is referring to a failed CI leg - https://dev.azure.com/dnceng/public/_build/results?buildId=1548836&view=logs&jobId=aaac6b38-f75f-5b74-6803-9c7a6ece1300&j=aaac6b38-f75f-5b74-6803-9c7a6ece1300&t=adc24de6-3810-5eb5-4a4f-f000ec649b58

This leg is still running with the aspnetcore fix - not sure why it isn't showing up today in GH checks.

@dougbu
Copy link
Member

dougbu commented Jan 18, 2022

This leg is still running with the aspnetcore fix - not sure why it isn't showing up today in GH checks.

Ah, you were describing the problem w/o this PR. Got it.

@MichaelSimons MichaelSimons merged commit a22825a into dotnet:release/6.0.1xx Jan 19, 2022
@MichaelSimons MichaelSimons deleted the issue-2706 branch January 19, 2022 13:47
@MichaelSimons MichaelSimons mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@crummel crummel crummel approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MichaelSimons @dougbu @crummel @safern