Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Build all packages when in source-build #63653

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

safern
Copy link
Member

@safern safern commented Jan 11, 2022

Fixes: #63451

@ghost
Copy link

ghost commented Jan 11, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #63451

Author: safern
Assignees: safern
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I created a patch from this and created a PR in installer to validate the e2e source-build scenario - dotnet/installer#13009

@safern
Copy link
Member Author

safern commented Jan 12, 2022

@MichaelSimons let me know when I'm good to merge after your e2e validation.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source-build testing looks good.

@safern safern merged commit beedfae into release/6.0 Jan 13, 2022
Infrastructure Backlog automation moved this from In Progress to Done Jan 13, 2022
@safern safern deleted the generatePackagesOnSourceBuild branch January 13, 2022 00:24
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants