Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable repo PvP for Arcade #16592

Merged
merged 1 commit into from
Jun 5, 2023
Merged

enable repo PvP for Arcade #16592

merged 1 commit into from
Jun 5, 2023

Conversation

oleksandr-didyk
Copy link

Contributes to dotnet/source-build#3043

@oleksandr-didyk oleksandr-didyk requested a review from a team as a code owner June 5, 2023 14:52
@oleksandr-didyk oleksandr-didyk mentioned this pull request Jun 5, 2023
Closed
26 tasks
@MichaelSimons MichaelSimons mentioned this pull request Jun 5, 2023
Closed
@MichaelSimons MichaelSimons merged commit 8b1dbc5 into dotnet:main Jun 5, 2023
16 checks passed
@mthalman
Copy link
Member

mthalman commented Jun 5, 2023

This error showed up as a result of these changes:

    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103: Unable to find a stable package NuGet.Commands with version (>= 6.2.2) [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 1 version(s) in previously-source-built [ Nearest version: 6.7.0-preview.1.32767 ] [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in source-built [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in prebuilt [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in reference-packages [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]

Have the SBRP changes not made it in to installer?

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Jun 5, 2023 •
edited
Loading

This error showed up as a result of these changes:

    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103: Unable to find a stable package NuGet.Commands with version (>= 6.2.2) [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 1 version(s) in previously-source-built [ Nearest version: 6.7.0-preview.1.32767 ] [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in source-built [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in prebuilt [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]
    /vmr/src/arcade/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1103:   - Found 0 version(s) in reference-packages [/vmr/src/arcade/artifacts/source-build/self/src/Arcade.sln]

Have the SBRP changes not made it in to installer?

I also see two prebuilts in my local VMR build with latest sha from main dotnet/dotnet@cca69ca:

    <Usage Id="NuGet.Commands" Version="6.2.2" File="src/arcade/artifacts/source-build/self/src/artifacts/obj/Microsoft.DotNet.Build.Tasks.Packaging/project.assets.json" IsDirectDependency="true" />
    <Usage Id="NuGet.Credentials" Version="6.2.2" File="src/arcade/artifacts/source-build/self/src/artifacts/obj/Microsoft.DotNet.Build.Tasks.Packaging/project.assets.json" />

@oleksandr-didyk
Copy link
Author

Have the SBRP changes not made it in to installer?

They did, but these two packages were not part of the 6.2.2 versions added into the SBRP. That's my bad, will add them as well.
I ran the VMR locally and it passed without pre-builts before opening the PR, so I probably miss-configured something, will check

@oleksandr-didyk oleksandr-didyk mentioned this pull request Jun 6, 2023
Merged
@oleksandr-didyk
Copy link
Author

dotnet/source-build-reference-packages#697 addresses the issue

@oleksandr-didyk oleksandr-didyk deleted the enable-repo-pvp-for-arcade branch September 26, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oleksandr-didyk @mthalman @NikolaMilosavljevic @MichaelSimons