Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass RepositoryName as a build argument in SourceBuild #19480

Conversation

andriipatsula
Copy link
Member

Ref Issue: dotnet/source-build#3898
Ref PRs: dotnet/arcade#14718

We aim to trace the origin of the artifacts we produce as part of SourceBuild. The Ref PR introduces a RepoOrigin attribute to the AssetManifest.xml file that will serve as an indicator of the artifact's source. The current proposal passes RepositoryName as a build argument in SourceBuild.

Test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2430776&view=artifacts&pathAsName=false&type=publishedArtifacts

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RepositoryName property is already available in the repo outer build so this change shouldn't be required. It's defined per repository in the eng/SourceBuild.props or eng/DotNetBuild.props file.

I think it just needs to be passed from the repo outer to the repo inner build: https://github.com/dotnet/arcade/blob/4c4025786b88439c9b97eee33cade3b1f2f75343/src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcadeBuild.targets#L57

@andriipatsula
Copy link
Member Author

I think it just needs to be passed from the repo outer to the repo inner build: https://github.com/dotnet/arcade/blob/4c4025786b88439c9b97eee33cade3b1f2f75343/src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcadeBuild.targets#L57

Thanks for feedback. Started a test build. I will let you know about the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants