Implement a RepoOrigin attribute within the AssetManifest.xml file. #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriipatsula
changed the title
This was referenced Apr 16, 2024
premun
previously approved these changes
Apr 18, 2024
src/VersionTools/Microsoft.DotNet.VersionTools/BuildManifest/Model/BlobArtifactModel.cs
Outdated
Show resolved
Hide resolved
src/VersionTools/Microsoft.DotNet.VersionTools/BuildManifest/Model/PackageArtifactModel.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
previously approved these changes
Apr 18, 2024
…odel/BlobArtifactModel.cs Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
…odel/PackageArtifactModel.cs Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcadeBuild.targets
Show resolved
Hide resolved
ViktorHofer
approved these changes
Apr 18, 2024
MichaelSimons
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Issue: dotnet/source-build#3898
Ref PRs: dotnet/runtime#101241
We aim to trace the origin of the artifacts we produce as part of SourceBuild. This proposal involves introducing a new attribute called RepoOrigin to the AssetManifest.xml file. This attribute will serve as an indicator of the artifact's source.
This is part of the solution that updates PushToBuildStorage.cs and Publish.proj. Next step is to pass the RepoName parameter as a build option in https://github.com/dotnet/installer/blob/main/src/SourceBuild/content/repo-projects/Directory.Build.props
Test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2433413&view=results
To double check: