Update dispose access modifier (#614)

* Changed from public to protected * Updated implementations
dotnet · Jul 22, 2019 · 030958a · 030958a
1 parent 322de72
commit 030958a
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 8 deletions.
diff --git a/src/System.Device.Gpio/System/Device/Gpio/GpioDriver.cs b/src/System.Device.Gpio/System/Device/Gpio/GpioDriver.cs
@@ -113,7 +113,7 @@ public void Dispose()
 
         protected virtual void Dispose(bool disposing)
         {
-            // Nothing to do in the base class.
+            // Nothing to do in base class.
         }
     }
 }
diff --git a/src/System.Device.Gpio/System/Device/I2c/Devices/UnixI2cDevice.Linux.cs b/src/System.Device.Gpio/System/Device/I2c/Devices/UnixI2cDevice.Linux.cs
@@ -241,13 +241,14 @@ public override unsafe void WriteRead(ReadOnlySpan<byte> writeBuffer, Span<byte>
             }
         }
 
-        public override void Dispose(bool disposing)
+        protected override void Dispose(bool disposing)
         {
             if (_deviceFileDescriptor >= 0)
             {
                 Interop.close(_deviceFileDescriptor);
                 _deviceFileDescriptor = -1;
             }
+
             base.Dispose(disposing);
         }
     }

diff --git a/src/System.Device.Gpio/System/Device/I2c/Devices/Windows10I2cDevice.Windows.cs b/src/System.Device.Gpio/System/Device/I2c/Devices/Windows10I2cDevice.Windows.cs
@@ -115,7 +115,7 @@ public override void WriteRead(ReadOnlySpan<byte> writeBuffer, Span<byte> readBu
             new Span<byte>(byteArray).CopyTo(readBuffer);
         }
 
-        public override void Dispose(bool disposing)
+        protected override void Dispose(bool disposing)
         {
             _winI2cDevice?.Dispose();
             _winI2cDevice = null;

diff --git a/src/System.Device.Gpio/System/Device/I2c/I2cDevice.cs b/src/System.Device.Gpio/System/Device/I2c/I2cDevice.cs
@@ -63,7 +63,7 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        public virtual void Dispose(bool disposing)
+        protected virtual void Dispose(bool disposing)
         {
             // Nothing to do in base class.
         }

diff --git a/src/System.Device.Gpio/System/Device/Spi/Devices/UnixSpiDevice.Linux.cs b/src/System.Device.Gpio/System/Device/Spi/Devices/UnixSpiDevice.Linux.cs
@@ -223,13 +223,14 @@ private unsafe void Transfer(byte* writeBufferPtr, byte* readBufferPtr, int buff
             }
         }
 
-        public override void Dispose(bool disposing)
+        protected override void Dispose(bool disposing)
         {
             if (_deviceFileDescriptor >= 0)
             {
                 Interop.close(_deviceFileDescriptor);
                 _deviceFileDescriptor = -1;
             }
+
             base.Dispose(disposing);
         }
     }

diff --git a/src/System.Device.Gpio/System/Device/Spi/Devices/Windows10SpiDevice.Windows.cs b/src/System.Device.Gpio/System/Device/Spi/Devices/Windows10SpiDevice.Windows.cs
@@ -118,7 +118,7 @@ public override void TransferFullDuplex(ReadOnlySpan<byte> writeBuffer, Span<byt
             byteArray.CopyTo(readBuffer);
         }
 
-        public override void Dispose(bool disposing)
+        protected override void Dispose(bool disposing)
         {
             _winDevice?.Dispose();
             _winDevice = null;

diff --git a/src/System.Device.Gpio/System/Device/Spi/SpiDevice.cs b/src/System.Device.Gpio/System/Device/Spi/SpiDevice.cs
@@ -56,9 +56,9 @@ public void Dispose()
             GC.SuppressFinalize(this);
         }
 
-        public virtual void Dispose(bool disposing)
+        protected virtual void Dispose(bool disposing)
         {
-            //Nothing to do in base class.
+            // Nothing to do in base class.
         }
     }
 }