Fixing an inverted timeout condition #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Card reading timeout should happen when dtTimeout < DateTime.Now not the other way around, otherwise ListenToCardIso14443TypeA(out Data106kbpsTypeA card, TimeSpan timeout) will always return false. i.e. since dtTimeout is in the future it will be always greater than DateTime.Now
ghost
added
the
area-device-bindings
krwq
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
LGTM, @Ellerbach please take a look in case you have any extra feedback (i.e. other methods which might need adjustment etc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: #1869
Card reading timeout should happen when dtTimeout < DateTime.Now not the other way around, otherwise ListenToCardIso14443TypeA(out Data106kbpsTypeA card, TimeSpan timeout) will always return false. i.e. since dtTimeout is in the future it will be always greater than DateTime.Now
Microsoft Reviewers: Open in CodeFlow