Made I2cDevice/SpiDevice ReadByte/WriteByte methods virtual #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jimmys20 looks good thank you, I assume this will get merged soon but API changes to System.Device.Gpio require at least two people to approve so we'll need to wait for those. |
pgrawehr
reviewed
Oct 1, 2022
gfoidl
reviewed
Oct 1, 2022
|
Sorry, I pressed "Re-request review" for gfoidl and it removed the other review requests. |
gfoidl
approved these changes
Oct 1, 2022
krwq
approved these changes
Oct 3, 2022
pgrawehr
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629
Made
WriteByte/ReadBytemethods virtual forI2cDeviceandSpiDeviceand removed the override methods from deriving classes that had same implementation as base methods.Microsoft Reviewers: Open in CodeFlow