Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate device listing #1966

Merged
merged 1 commit into from Oct 25, 2022
Merged

Conversation

krwq
Copy link
Member

@krwq krwq commented Oct 25, 2022

Quickly regenerate device listing so it's up to date.

I've also removed HT16k33 folder since it's now under Display

Microsoft Reviewers: Open in CodeFlow

@@ -52,6 +52,7 @@
"power",
"voc",
"thermocouple",
"weight",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you are there, don't you want to make the little changes used here to move to a json file? :-) https://github.com/nanoframework/Samples/tree/main/device-listing

If not, no worry, that can be done later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to do that later, unfortunately don't have much time this week as I'm preparing for .NET Conf and I'd like the new devices to be available on device listing since they're used in the presentation :-)

@@ -32,6 +32,7 @@
* [Charlieplex Segment binding](Charlieplex/README.md)
* [Cpu Temperature](CpuTemperature/README.md)
* [DC Motor Controller](DCMotor/README.md)
* [DFRobot KIT0176: I2C 1kg Weight Sensor Kit - HX711 (Gravity: I2CWeight Sensor)](Hx711I2c/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while regenerating this file, what about going to the title of the README and adjusting them to add more about the device names? Like this one: https://github.com/dotnet/iot/blob/main/src/devices/Bmxx80/README.md
Would be great to list of the devices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #1967 to track all comments you've put here but unfortunately I'd prefer this one was scoped to simple change. I was thinking about doing this before I opened PR but realized I'm a bit short on time so decided to just do simple change

@@ -31,8 +31,9 @@ Our vision: the majority of .NET bindings are written completely in .NET languag
* [ADXL345 - Accelerometer](Adxl345/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reorder the file as well by alphabetic order?

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the issue to track what needs to be improved

@krwq krwq merged commit f100e3e into dotnet:main Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants