Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows Helix test execution #1976

Merged
1 commit merged into from Nov 7, 2022

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Nov 4, 2022

Windows.10.Arm32.Iot devices are being removed from Helix, so removing their usage here (still get similar coverage from Raspbian Unix legs)

Microsoft Reviewers: Open in CodeFlow

@joperezr
Copy link
Member

joperezr commented Nov 4, 2022

LGTM, thanks for taking care of this @MattGal.

FYI: @krwq @raffaeler @pgrawehr @Ellerbach @richlander After this goes in, we will stop running our hardware tests against windows iot core. We've talked about doing this in the past, but if needed I can share more info during our standup next week.

@joperezr joperezr added the Auto-Merge When added to a PR, it will be automatically merged after all checks pass. label Nov 4, 2022
@ghost
Copy link

ghost commented Nov 4, 2022

Hello @joperezr!

Because this pull request has the Auto-Merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 15 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pgrawehr
Copy link
Contributor

pgrawehr commented Nov 5, 2022

@MattGal Can you also take a look at the linux device ddvsorpil022? In all of the recent linux helix failures, this system seems to have been part of it. Maybe a hard reboot will do, otherwise I'd call this one broken.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ghost ghost merged commit 51a3e80 into dotnet:main Nov 7, 2022
richlander pushed a commit to richlander/iot that referenced this pull request Nov 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-Merge When added to a PR, it will be automatically merged after all checks pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants