Hand-over unmute parameter #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
joperezr
reviewed
Dec 1, 2022
| /// <returns>A communications channel to a sound device running on Unix.</returns> | ||
| public static SoundDevice Create(SoundConnectionSettings settings) => new UnixSoundDevice(settings); | ||
| /// <remarks>Some device do not support to be unmuted, if you try so, it will raise an exception and dispose the device. In this case, you should set the unmute parameter to false</remarks> | ||
| public static SoundDevice Create(SoundConnectionSettings settings, bool unmute = true) => new UnixSoundDevice(settings, unmute); |
There was a problem hiding this comment.
This is a binary breaking change against the previous version of the library, which is why the builds in Windows are failing. Could you please instead create a new constructor where the unmute param is not defaulted? That way we won't have the breaking change.
joperezr
added
the
Needs: Author Feedback
ghost
removed
the
Needs: Author Feedback
pgrawehr
approved these changes
Dec 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some device(e.g. the alsa softvol plugin) do not support to be unmuted, if you try so, it will raise an exception and dispose the device.
Microsoft Reviewers: Open in CodeFlow