Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding for generic HX711 (load cell amplifier and 24-Bit ADC Module) driver #1994

Merged
merged 18 commits into from Jul 16, 2023

Conversation

matteo-tosi
Copy link
Contributor

@matteo-tosi matteo-tosi commented Dec 7, 2022

Driver used by read weight of any load cell.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Dec 7, 2022
@dnfadmin
Copy link

dnfadmin commented Dec 7, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition, couple of questions and some remarks on naming conventions mainly

src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
src/devices/Hx711/ByteFormat.cs Outdated Show resolved Hide resolved
src/devices/Hx711/HX711Options.cs Outdated Show resolved Hide resolved
src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
src/devices/Hx711/README.md Show resolved Hide resolved
src/devices/Hx711/README.md Outdated Show resolved Hide resolved
src/devices/Hx711/README.md Show resolved Hide resolved
src/devices/Hx711/README.md Show resolved Hide resolved
src/devices/README.md Outdated Show resolved Hide resolved
@matteo-tosi
Copy link
Contributor Author

Thanks for this nice addition, couple of questions and some remarks on naming conventions mainly

@Ellerbach
It was a pleasure.
I think I have solved all points. Let me know if there's anything else.

@Ellerbach
Copy link
Member

Thanks for this nice addition, couple of questions and some remarks on naming conventions mainly

@Ellerbach It was a pleasure. I think I have solved all points. Let me know if there's anything else.

Please check the Markdown linter, I pointed the obvious, but you have some hidden ;-)
image

Check as well while things are failing for the rest in the tests. Otherwise, all up, looks good to me. I'll have another look a bit later.

@matteo-tosi
Copy link
Contributor Author

Thanks for this nice addition, couple of questions and some remarks on naming conventions mainly

@Ellerbach It was a pleasure. I think I have solved all points. Let me know if there's anything else.

Please check the Markdown linter, I pointed the obvious, but you have some hidden ;-) image

Check as well while things are failing for the rest in the tests. Otherwise, all up, looks good to me. I'll have another look a bit later.

I haven't more warning in my Markdown linter, but validation fail. What's wrong? I can't see pipeline details. Thanks for support.

@Ellerbach
Copy link
Member

I haven't more warning in my Markdown linter, but validation fail. What's wrong? I can't see pipeline details. Thanks for support.

No worry, the other warning are the link checker which is far to be perfect (we will remove it from the pipeline). Thanks!

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition, looks good to me. Let's wait for someone else to have a look.

src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
src/devices/Hx711/HX711.cs Outdated Show resolved Hide resolved
@matteo-tosi
Copy link
Contributor Author

@krwq there are still some pending points, if you give me an answer I'll see if I can correct the code so as to close the pr. Thank you very much. Happy Holidays!

@krwq krwq self-assigned this Jan 12, 2023
@joperezr
Copy link
Member

/azp run dotnet.iot

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matteo-tosi
Copy link
Contributor Author

@dotnet-policy-service agree

@krwq
Copy link
Member

krwq commented Jul 13, 2023

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 1994 in repo dotnet/iot

@pgrawehr
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr pgrawehr merged commit 489759a into dotnet:main Jul 16, 2023
9 checks passed
@pgrawehr
Copy link
Contributor

@matteo-tosi Thanks for this addition!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants