Adding AM2320 (migration from .NET nanoFramework) #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
pgrawehr
reviewed
Dec 24, 2022
pgrawehr
reviewed
Dec 25, 2022
src/devices/Am2320/Am2320.cs
Outdated
| /// <returns>True on success, false if reading failed.</returns> | ||
| [Telemetry("Temperature")] | ||
| public bool TryReadTemperature( | ||
| #if NET5_0_OR_GREATER |
There was a problem hiding this comment.
This is not really necessary here, since Temperature is a value type.
pgrawehr
reviewed
Dec 26, 2022
Comment on lines
26
to
28
| am2330.TryReadTemperature(out Temperature temp); | ||
| am2330.TryReadHumidity(out RelativeHumidity hum); | ||
| if (am2330.IsLastReadSuccessful) |
There was a problem hiding this comment.
I suggest to show how to do it right: if (am2330.TryReadTemperature(out Temperature temp) && ...
There was a problem hiding this comment.
Great catch! You're fully right!
pgrawehr
approved these changes
Dec 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding AM2320
Origin: https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Am2320
Microsoft Reviewers: Open in CodeFlow