Adjust for ConfigurableFirmata V3 #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run dotnet.iot |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pgrawehr
force-pushed
the
ConfigurableFirmataV3_Adjust1
branch
from
dfb61be
to
c1168b6
Compare
joperezr
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
These are the types of breaks that I was afraid of and that we should prevent by not having this leg run on CI. We have also been pinged by the infrastructure crew on an effort to try to reduce build times when possible, so I think the best course of action is to disable this leg from running as part of CI. We can keep the script around and running locally, or we can also have a separate pipeline for running it, and that way we can be able to run it on demand on a PR when making changes around the area.
|
Merging to unblock other PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed reference to a deleted file
Removed outdated sample file (use the one in the Firmata repo instead, should be officially published shortly)
Microsoft Reviewers: Open in CodeFlow