Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .markdown-link-check.json #2056

Merged
merged 4 commits into from Mar 18, 2023
Merged

Update .markdown-link-check.json #2056

merged 4 commits into from Mar 18, 2023

Conversation

krwq
Copy link
Member

@krwq krwq commented Mar 18, 2023

Ignore links to internal builds from link checker. They are used as documentation for how to release.

Fixes issue seen in: #2055

Microsoft Reviewers: Open in CodeFlow

Ignore links to internal builds from link checker. They are used as documentation for how to release.
@krwq
Copy link
Member Author

krwq commented Mar 18, 2023

@pgrawehr @Ellerbach any clues why is the pattern not working? Is the build picking this up after it's merged?

@pgrawehr
Copy link
Contributor

This is indeed strange, given that a) that URL is already excluded from checking and b) this is confirmed when I run the test locally:

FILE: C:\projects\iot2\Documentation\creating-new-release.md
  [✓] https://github.com/dotnet/iot/tree/master/tools/device-listing → Status: 200
  [/] https://dev.azure.com/dnceng/internal/_build?definitionId=239 → Status: 0
  [✓] https://github.com/dotnet/iot/releases/tag/1.2 → Status: 200
  [✓] https://github.com/dotnet/iot/compare/1.1...1.2 → Status: 200
  [✓] https://github.com/dotnet/iot/pull/1310 → Status: 200
  [✓] https://github.com/dotnet/iot/pulls?q=is%3Apr+Bump+System.Device.Gpio+is%3Aclosed+author%3Aapp%2Fdependabot → Status: 200
  [✓] https://github.com/dotnet/iot/pulls?q=is%3Apr+Bump+Iot.Device.Bindings+is%3Aclosed+author%3Aapp%2Fdependabot → Status: 200
  [✓] https://github.com/dotnet/iot-api-docs → Status: 200

  8 links checked.

(the [/] means that the check of that link is skipped.)

It seems that the build is completely ignoring the .json file.

@pgrawehr
Copy link
Contributor

Great. The issue is an update of the mardown-link-checker. If I use the latest version, it behaves the same.

The latest version (3.11.0) is broken. It completely ignores the
configuration file.
@pgrawehr pgrawehr closed this Mar 18, 2023
@pgrawehr pgrawehr deleted the krwq-patch-3 branch March 18, 2023 19:35
@pgrawehr pgrawehr restored the krwq-patch-3 branch March 18, 2023 19:36
@pgrawehr pgrawehr reopened this Mar 18, 2023
@pgrawehr
Copy link
Contributor

@krwq Fixed the issue by nailing to the older version of the markdown-link-checker.

@pgrawehr
Copy link
Contributor

Issue created here: tcort/markdown-link-check#246

@krwq krwq merged commit ec29dad into main Mar 18, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants