Add new display device - Pimoroni Four letter phat display #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
|
@dotnet-policy-service agree |
|
@dotnet-policy-service agree
… On 6 Aug 2023, at 17:55, dotnet-policy-service[bot] ***@***.***> wrote:
@dotnet-policy-service agree
|
pgrawehr
reviewed
Aug 6, 2023
src/devices/Display/samples/Large4Digit14SegmentDisplay/Program.cs
Outdated
Show resolved
Hide resolved
|
/azp run dotnet.iot |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixed issues with Markdown on windows build
- Letter B Fixed - Console output removed - Changed accessibility for unnecessary public write method - Added '.' do degrees display in sample - removed no longer require IFourteenSegmentDisplay interface - intenalised FontHelper.cs (added WriteHex and WriteChar to display. TO-DO: - Fix more chars in Font14.cs - Fix broken WirteChar
Ellerbach
reviewed
Aug 7, 2023
|
Thanks for all your comments so far. V helpful. |
pgrawehr
approved these changes
Aug 9, 2023
|
/azp run dotnet.iot |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fix broken link
MD markup creates too large an image. Reverted to html...
Ellerbach
reviewed
Aug 9, 2023
|
/azp run dotnet.iot |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Merging ad all approved and all green! Thanks again for the contribution @t1mr0dg3r5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code based on the existing 7 segment display utilising the HT16K33 chipset.
https://shop.pimoroni.com/products/four-letter-phat?variant=39256047178
Microsoft Reviewers: Open in CodeFlow