Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSD13xx binding, add unified interface for graphic displays #2156

Merged
merged 16 commits into from Nov 11, 2023

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Nov 3, 2023

Fixes #1615

Remove ImageSharp from example, use SkiaSharp instead. Move initialization code and other important functions into binding.

Also added a new GraphicDisplay base class. Every display should implement these methods as a minimum.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's called cleaning! Thanks for this heavy effort and the last adjustment needed for those screen work!

@pgrawehr pgrawehr added this to the v3.1.0 milestone Nov 9, 2023
…ixesNextVersion

# Conflicts:
#	src/Iot.Device.Bindings/CompatibilitySuppressions.xml
#	src/devices/Media/Media.sln
@pgrawehr pgrawehr merged commit 731e4d0 into dotnet:main Nov 11, 2023
9 checks passed
@pgrawehr pgrawehr deleted the MediaGraphicFixesNextVersion branch November 11, 2023 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSD13xx: need to move code from the sample to the bindings
2 participants