Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a few new messages, fix warnings from AisManager #2158

Merged
merged 10 commits into from Nov 9, 2023
Merged

Add support for a few new messages, fix warnings from AisManager #2158

merged 10 commits into from Nov 9, 2023

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Nov 5, 2023 •
edited by ghost

Fixes #2143

  • Added support for a few new NMEA messages (namely the SeaSmart messages for Engine Detail, Engine Fast update and Fluid Level). These messages directly wrap NMEA2000 messages, but are understood by several converters.
  • Fixed AisManager proximity warnings. CPA and TCPA values of nearby vessels should now be correct
  • Fixed calculation of magnetic deviation table - do not remove data due to unclear constraints
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Nov 5, 2023
Ellerbach
Ellerbach approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again on all those navigation elements.

src/devices/Nmea0183/Sentences/FluidData.cs Outdated Show resolved Hide resolved
@pgrawehr pgrawehr added this to the v3.1.0 milestone Nov 9, 2023
@pgrawehr pgrawehr merged commit c8754ec into dotnet:main Nov 9, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees
No one assigned
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

AIS Manager is not properly calculating safety information
2 participants
@pgrawehr @Ellerbach