Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt FTX232H to support new variants (FT232HP, FT2232HP, FT2232HA FT4232HA, FT4232HP) #2306

Merged
merged 2 commits into from
May 2, 2024

Conversation

mbenazechJlsa
Copy link
Contributor

@mbenazechJlsa mbenazechJlsa commented Apr 25, 2024

  • Update FT device types from D2XX lib with new variants
  • Adapt FTX232H to support new variants (FT232HP, FT2232HP, FT2232HA FT4232HA, FT4232HP)
  • Fix Channel when SerialNumber is present
Microsoft Reviewers: Open in CodeFlow

* Adapt FTX232H to support new variants (FT232HP, FT2232HP, FT2232HA FT4232HA, FT4232HP)
* Fix Channel when SerialNumber is present
@mbenazechJlsa
Copy link
Contributor Author

mbenazechJlsa commented Apr 25, 2024 via email

@krwq krwq requested a review from Ellerbach April 25, 2024 15:42
@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the improvement! Look great.

@Ellerbach
Copy link
Member

One thing missing is adjusting the README to add the new device support in the list.

@Ellerbach
Copy link
Member

@krwq if you want to have a review as well.

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ellerbach Ellerbach merged commit 8460898 into dotnet:main May 2, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants