Changes to start pushing packages to blob Feed and to BAR #361
Conversation
|
@joperezr Are these OOB packages shipping on their own schedule? |
|
No, they are shipping along with .NET Core 3.0 and its previews. Is that ok? |
|
Okay, are they referenced in other repos? |
|
No, just referenced by this same repo. No other dotnet repo depends on these two packages. |
| strategy: | ||
| matrix: | ||
| release_configuration: | ||
| _BuildConfig: Release |
There was a problem hiding this comment.
nit: you could also just set this as
variables:
- _BuildConfig: ReleaseThere was a problem hiding this comment.
true in this case since we only build the one configuration but I leave as is if that's ok for consistency with the other jobs which do have more than one configuration.
| @@ -239,7 +270,7 @@ jobs: | |||
| KeyVaultName: EngKeyVault | |||
| SecretsFilter: 'dotnet-myget-org-api-key' | |||
| - script: powershell -ExecutionPolicy ByPass -NoProfile -command "& """$(Build.SourcesDirectory)\eng\common\Build.ps1""" -restore" && | |||
| for /f %%x in ('dir /s /b $(Build.SourcesDirectory)\artifacts\packages\pushToMyGet\*.nupkg') do $(Build.SourcesDirectory)\.dotnet\dotnet.exe nuget push %%x -k $(dotnet-myget-org-api-key) -s https://dotnet.myget.org/F/dotnet-core/ | |||
| for /f %%x in ('dir /s /b $(Build.SourcesDirectory)\artifacts\packages\pushToMyGet\*.nupkg') do dotnet nuget push %%x -k $(dotnet-myget-org-api-key) -s https://dotnet.myget.org/F/dotnet-core/ | |||
There was a problem hiding this comment.
Does Arcade really not provide support for publishing to myget?
Rather than using the AzureKeyVault task above, I'd suggest you use the "DotNet-MyGet-Publish" variable group.
variables:
- group: DotNet-MyGet-PublishThere was a problem hiding this comment.
It might support it, but at least it didn't back when I initially added this since we were moving away from it. I'll switch to use the group as you suggest.
Since these packages do not have direct dependencies on the latest core-setup (Microsoft.NETCore.App) and no one else depends on them, they are a bit more like OOB packages and aligning with previews is more about you choosing an appropriate build and doing the package push when needed. For completeness, you should add a default channel for this repo: darc add-default-channel --channel ".NET Core 3 Dev" --repo https://github.com/dotnet/iot --branch refs/heads/master |
cc @safern @chcosta
Adding required changes in order to publish packages to blob feed and to update BAR with each official build.
@mmitche is there anything additional to these changes needed in order to be included in the official shipping train?