Adding UnixI2cDevice Implementations #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
reviewed
Nov 29, 2018
|
CC @stephentoub as he had a good feedback on other PR's. |
|
FYI @shaggygi |
tarekgh
reviewed
Nov 29, 2018
src/System.Device.Gpio/System/Device/I2c/Drivers/UnixI2cDevice.Linux.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 29, 2018
src/System.Device.Gpio/System/Device/I2c/Drivers/UnixI2cDevice.Linux.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 29, 2018
src/System.Device.Gpio/System/Device/I2c/Drivers/UnixI2cDevice.Linux.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 29, 2018
| int result = Interop.ioctl(_deviceFileDescriptor, (uint)I2cSettings.I2C_RDWR, new IntPtr(&tr)); | ||
| if (result < 0) | ||
| { | ||
| throw new IOException("Error when attempting to perform the I2c data transfer."); |
There was a problem hiding this comment.
"Error when attempting to perform the I2c data transfer. [](start = 38, length = 56)
don't we support resource files in such libraries?
There was a problem hiding this comment.
I believe we do, but we haven't been using resource files yet. I'll log an issue for this so that we move all of these strings to a resource file instead.
tarekgh
reviewed
Nov 29, 2018
src/System.Device.Gpio/System/Device/I2c/Drivers/UnixI2cDevice.Linux.cs
Outdated
Show resolved
Hide resolved
5 tasks
JohnTasler
approved these changes
Nov 29, 2018
tarekgh
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @JohnTasler @tarekgh
This PR will fix the namespaces that were wrong in #50 , and will also add the implementation for the Unix I2c device.