Port single-file analyzer #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlakollo
reviewed
Dec 3, 2020
test/ILLink.RoslynAnalyzer.Tests/AvoidAssemblyLocationInSingleFileTests.cs
Show resolved
Hide resolved
tlakollo
reviewed
Dec 3, 2020
test/ILLink.RoslynAnalyzer.Tests/AvoidAssemblyLocationInSingleFileTests.cs
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Dec 3, 2020
tlakollo
approved these changes
Dec 3, 2020
tlakollo
reviewed
Dec 3, 2020
test/ILLink.RoslynAnalyzer.Tests/AvoidAssemblyLocationInSingleFileTests.cs
Outdated
Show resolved
Hide resolved
agocke
reviewed
Dec 4, 2020
test/ILLink.RoslynAnalyzer.Tests/AvoidAssemblyLocationInSingleFileTests.cs
Outdated
Show resolved
Hide resolved
agocke
reviewed
Dec 4, 2020
| { | ||
| public static class MSBuildPropertyOptionNames | ||
| { | ||
| public const string PublishSingleFile = nameof (PublishSingleFile); |
There was a problem hiding this comment.
We probably need to add PublishTrimmed now since otherwise all the trim warnings will automatically be turned on during single-file
There was a problem hiding this comment.
Wouldn't be better to think about the more general area than to hardcode the single narrow scenario? Are we going to add a property for each of remaining scenario which would benefit from the same logic?
There was a problem hiding this comment.
Perhaps there's some broader feature work we could do, but we certainly need to recognize whether trimming or single-file are enabled, so we at least need to recognize the two MSBuild properties that already exist.
agocke
approved these changes
Dec 8, 2020
test/ILLink.RoslynAnalyzer.Tests/AvoidAssemblyLocationInSingleFileTests.cs
Show resolved
Hide resolved
test/ILLink.RoslynAnalyzer.Tests/RequiresUnreferencedCodeAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 8, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Add single-file analyzer * Add tests * Use str constant * Update Resources * Update tests * PR feedback * Remove mysterious filename from comments * Add helper method for single-file diagnostic verification * Refactor MSBuild properties * Add test with PublishSingleFile not set Commit migrated from dotnet/linker@a86658f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.