Remove single-file analyzer #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please retarget the PR to https://github.com/dotnet/roslyn-analyzers/tree/release/6.0.1xx-preview1 branch? We are using that branch for all new analyzers/removed analyzers for .NET 6 release. |
mavasani
approved these changes
Jan 8, 2021
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx-preview1 #4680 +/- ##
==========================================================
Coverage 95.76% 95.77%
==========================================================
Files 1185 1183 -2
Lines 268083 267838 -245
Branches 16184 16175 -9
==========================================================
- Hits 256743 256518 -225
+ Misses 9245 9224 -21
- Partials 2095 2096 +1 |
mavasani
reviewed
Jan 11, 2021
mavasani
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This analyzer was ported to mono/linker. Moving forward, the analyzer will be packed and flown to the SDK via the linker repo (see dotnet/sdk#15239); we need to remove it from here, otherwise we'll be seeing duplicate diagnostics.