Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Basic tests vs CoreCLR require catching an exception #12

Closed
AndyAyersMS opened this issue Feb 13, 2015 · 4 comments · Fixed by #952
Closed

Basic tests vs CoreCLR require catching an exception #12

AndyAyersMS opened this issue Feb 13, 2015 · 4 comments · Fixed by #952

Comments

@AndyAyersMS
Copy link
Member

In the current CoreCLR/CoreFX drops, tests that write to the console will require the jit to generate code that can handle exceptions, unless the current code page is 65001 (my cmd shell defaults to CP 437).

In particular we see a throw from a protected block in System.Text.Encoding.GetEncoding(int32 codePage) with a local catch.

Given that MSILC won't be in a position to generate correct code for catches for a while, we need a workaround -- either set the code page when running the tests, avoid tests that write to the console, get CoreFx to look at whether this behavior is reasonable, or blacklist that method in our jit and allow the production jit to handle it.

@AndyAyersMS
Copy link
Member Author

Opened an issue for CoreCLR guys to look into this.

@AndyAyersMS
Copy link
Member Author

There's a fix coming. Will update this when I know specifically where it shows up.

@AndyAyersMS
Copy link
Member Author

I am pretty sure this is fixed. The fix has been in CoreFX for a while but couldn't make it into the build of the CoreCLR tests until that build was switched over to the new nuget schema.

I'll verify this and then remove the chcp's from our various scripts.

@AndyAyersMS
Copy link
Member Author

I haven't been doing the chcp thing in a long time. Will PR updating the test script not to do it either.

AndyAyersMS added a commit to AndyAyersMS/llilc that referenced this issue Nov 20, 2015
The issue in CoreFX that lead to us needing to run tests in code page 65001 is long since fixed. So remove the chcp from our test scripts and docs.

Closes dotnet#12.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant